Replace declare ng.ui with declare angular.ui. Fixes #2035
#2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcollette
changed the title
declare ng.ui with declare angular.ui. Fixes 2035declare ng.ui with declare angular.ui. Fixes #2035
|
This should be addressed with 63f4476 from #1990. Please use the implementation in https://github.com/borisyankov/definitelytyped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the TS 1.5 language service does not yet support the exclude option, IDEs such as WebStorm will find and use angular-ui-router.d.ts.
As discussed in issue 2035, the declaration ng.ui conflicts with the declaration of ng in angular.d.ts.
This merge is to correct the declaration from ng.ui to angular.ui
Pull 1990 is attempting to address the issue by removing the definition entirely from the project, which is fine as well.
Either way, the issue is a blocker for those compiling with an IDE (i.e. perhaps not using a gulpfile).
Hopefully one of the two pulls will be merged ASAP.
Fixes #2035