Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular-ui-router.d.ts): Delete angular-ui-router.d.ts #1990

Closed
wants to merge 1 commit into from

Conversation

kenhowardpdx
Copy link
Contributor

This file is out of date and breaks the build process. Deleting to defer to the community supported DefinitelyTyped version - DefinitelyTyped/DefinitelyTyped#4035

This file is out of date and breaks the build process. Deleting to defer to the community supported DefinitelyTyped version - DefinitelyTyped/DefinitelyTyped#4035
@pocesar
Copy link

pocesar commented Aug 9, 2015

the one at DefinitelyTyped is actively maintained

@nateabele
Copy link
Contributor

@christopherthielen @wesleycho Is this still relevant in the context of new things?

@christopherthielen
Copy link
Contributor

I've been adding type information to everything I touch, but that includes internal classes≥
I think we'll be generating our own .d.ts file for public consumption.

@nateabele
Copy link
Contributor

Okay, so we're basically dropping this one anyway. Then I guess we can merge this, but the formatting issues need to be fixed: http://prjs.radify.io/#/angular-ui/ui-router/pulls/1990

@kenhowardpdx kenhowardpdx changed the title Delete angular-ui-router.d.ts fix(angular-ui-router.d.ts) Delete angular-ui-router.d.ts Aug 12, 2015
@kenhowardpdx kenhowardpdx changed the title fix(angular-ui-router.d.ts) Delete angular-ui-router.d.ts fix(angular-ui-router.d.ts): Delete angular-ui-router.d.ts Aug 12, 2015
@kenhowardpdx
Copy link
Contributor Author

@nateabele I've fixed the title but it's still failing the format check. What do I need to do to get this merged?

@wesleycho
Copy link
Contributor

The commit format is off - this could be an easy thing to fix by us, although generally contributions should conform to the guidelines, as mentioned here.

@wesleycho wesleycho added this to the 0.2.16 milestone Sep 23, 2015
@wesleycho wesleycho closed this in 63f4476 Sep 23, 2015
@kenhowardpdx
Copy link
Contributor Author

@wesleycho Thanks. I'll look at the guidelines and re-submit a PR.

@wesleycho
Copy link
Contributor

No need, already merged it in :)

@kenhowardpdx
Copy link
Contributor Author

Oh. Ok. 👍

ExpFront pushed a commit to ExpFront/ui-router that referenced this pull request Jun 23, 2016
- Defer to the community generated DefinitelyTyped file

Closes angular-ui#1990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants