-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular-ui-router.d.ts): Delete angular-ui-router.d.ts #1990
Conversation
This file is out of date and breaks the build process. Deleting to defer to the community supported DefinitelyTyped version - DefinitelyTyped/DefinitelyTyped#4035
the one at DefinitelyTyped is actively maintained |
@christopherthielen @wesleycho Is this still relevant in the context of new things? |
I've been adding type information to everything I touch, but that includes internal classes≥ |
Okay, so we're basically dropping this one anyway. Then I guess we can merge this, but the formatting issues need to be fixed: http://prjs.radify.io/#/angular-ui/ui-router/pulls/1990 |
@nateabele I've fixed the title but it's still failing the format check. What do I need to do to get this merged? |
The commit format is off - this could be an easy thing to fix by us, although generally contributions should conform to the guidelines, as mentioned here. |
@wesleycho Thanks. I'll look at the guidelines and re-submit a PR. |
No need, already merged it in :) |
Oh. Ok. 👍 |
- Defer to the community generated DefinitelyTyped file Closes angular-ui#1990
This file is out of date and breaks the build process. Deleting to defer to the community supported DefinitelyTyped version - DefinitelyTyped/DefinitelyTyped#4035