Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(typeahead): update isOpen on escape #5587

Closed
wants to merge 1 commit into from

Conversation

deeg
Copy link
Contributor

@deeg deeg commented Mar 5, 2016

deeg added a commit to deeg/bootstrap that referenced this pull request Mar 5, 2016
This updates isOpen immediately when pressing escape button.

Fixes angular-ui#5579
Closes angular-ui#5587
@wesleycho
Copy link
Contributor

In this case, looks like scope.$parent.$digest() would be sufficient, as seen here

This updates isOpen immediately when pressing escape button.

Fixes angular-ui#5579
Closes angular-ui#5587
@deeg
Copy link
Contributor Author

deeg commented Mar 5, 2016

Plunker and code updated.

@wesleycho wesleycho added this to the 1.2.3 milestone Mar 5, 2016
@wesleycho
Copy link
Contributor

LGTM

@wesleycho wesleycho closed this in 313ba83 Mar 5, 2016
@deeg deeg deleted the typeahead-esc branch April 12, 2016 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typeahead is-open does not update when typeahead closes from escape keydown
2 participants