Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Typeahead is-open does not update when typeahead closes from escape keydown #5579

Closed
ryanyuyu opened this issue Mar 3, 2016 · 1 comment
Closed

Comments

@ryanyuyu
Copy link

ryanyuyu commented Mar 3, 2016

Bug description:

typeahead-is-open does not update when typeahead closes from escape keydown. To reproduce this, simply type some text and the hit the escape key. The typeahead menu will close itself, but the variable bound to typeahead-is-open does not update. It updates twice after being reopened with new inputs.

Link to minimally-working plunker that reproduces the issue: http://plnkr.co/edit/7RdEQhwudXOA6JkPkTsH?p=preview

Version of Angular, UIBS, and Bootstrap

Angular: 1.4.7, 1.5.0

UIBS: 1.2.1 (with templates)

Bootstrap: 3.3.6

@wesleycho
Copy link
Contributor

Modified the Plunker to show open state too here for quicker validation for whoever works on this - this indeed looks like a bug.

deeg added a commit to deeg/bootstrap that referenced this issue Mar 5, 2016
This updates isOpen immediately when pressing escape button.

Fixes angular-ui#5579
deeg added a commit to deeg/bootstrap that referenced this issue Mar 5, 2016
This updates isOpen immediately when pressing escape button.

Fixes angular-ui#5579
Closes angular-ui#5587
deeg added a commit to deeg/bootstrap that referenced this issue Mar 5, 2016
This updates isOpen immediately when pressing escape button.

Fixes angular-ui#5579
Closes angular-ui#5587
@wesleycho wesleycho added this to the 1.2.3 milestone Mar 5, 2016
@wesleycho wesleycho removed the PRs plz! label Mar 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants