fix(modal): backdrop animation on AngularJS 1.4 #3899
Conversation
| @@ -142,6 +142,7 @@ describe('$modal', function () { | |||
| function open(modalOptions) { | |||
| var modal = $modal.open(modalOptions); | |||
| $rootScope.$digest(); | |||
| $timeout.flush(0); | |||
There was a problem hiding this comment.
Does the 0 need to be passed in?
There was a problem hiding this comment.
There's a test that has a $timeout resolve , this prevents flushing that timeout (all timers are flushed when no args are given) so that that test is successful.
This really is supposed to just run the next tick, it's only for resolving the newly added $q promises, since there weren't any $timeout timers added.
|
Hm, I think a comment explaining the behavior would be good - otherwise, this LGTM. |
chrisirhc
force-pushed
the
feature/fix-backdrop-animate
branch
2 times, most recently
from
f7ed003 to
b2b709f
Compare
|
Added a comment and updated the variable names to hopefully clarify things. |
chrisirhc
force-pushed
the
feature/fix-backdrop-animate
branch
from
b2b709f to
158d267
Compare
|
Looks good here |
|
This is really important for us, can you make a 0.13.1 release soon with this included? |
|
👍 |
|
Any updates about the release? |
|
When I built 13.1 based on 158d267 it fixed the problems I was experiencing. Thank you! Looking forward to the official release 🍻 |
Fixes #3896