fix(modal): closing breaks on missing scope, 1.4

[chrisirhc]

• supports Angular 1.4

Fixes #3787
Fixes #3806
Fixes #3873
Closes #3888

[wesleycho]

This is meant to supersede my PR, correct?

[chrisirhc]

Yes, I think it fixes the root cause of a lot of issues in the repo.

[wesleycho]

LGTM

[iamdey]

Thank you @chrisirhc, unfortunatly there is still a bug in your plnkr you gave http://plnkr.co/edit/R8322USvwVICHy8wjM7Y?p=preview :

• the backdrop element is still in the DOM and prevent the modal to be open again.

Other bug in the animation :

• the modal just shows up without animation (top to middle)
• the modal just disapears without animation (middle to top)

It requires to wait the animation is finished before removing element from DOM : I've started this hack that uses the event from $animate : https://github.com/esion/bootstrap/pull/1/files#diff-15d409302580c93c654a382e2da68396R245
demo

[chrisirhc]

@esion you're right, I haven't fixed the backdrop animation. I'll make another PR for that in a bit.

[chrisirhc]

@esion , I've just submitted a PR #3899 to fix the issue you're having.
Updated Plunker: http://plnkr.co/edit/WlA6T6I63Og4Hkmk2FIh?p=preview

[vamsibassetty08]

I've tried animation off globally and inclusion ngAnimate but still the backdrop doesn't close the modal with angular 1.3.2 and angular-ui-bootstrap 0.12.0. Even I tried with angular-ui-bootstrap 0.13.0 & 0.13.1 etc but still modal doesn't close as backdrop is still present..

Any other alternatives?