Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Autofocus corrects the second time that the modal is open #2945

Closed
wants to merge 2 commits into from
Closed

Autofocus corrects the second time that the modal is open #2945

wants to merge 2 commits into from

Conversation

ddomingues
Copy link
Contributor

Autofocus corrects the second time that the modal is open. This fixes the issue #2802.
Example: http://plnkr.co/4sX9F3hObN0YmTU15m06

@wilg
Copy link

wilg commented Nov 10, 2014

👍 Looks good to me, and is desperately needed.

@jlzhao27
Copy link

+1, we really need this as well.

@hilnius
Copy link

hilnius commented Dec 18, 2014

+1, also need this

@bcaudan
Copy link

bcaudan commented Dec 19, 2014

+1

1 similar comment
@haches
Copy link

haches commented Mar 4, 2015

+1

@karianna
Copy link
Contributor

karianna commented Mar 4, 2015

@ddomingues Are you able to add/alter the tests for this?

@ddomingues
Copy link
Contributor Author

Ok @karianna . I'll do.

@haches
Copy link

haches commented Mar 5, 2015

@ddomingues @karianna thanks in advance. Would be awesome to have this PR merged.

@karianna karianna added this to the 0.13.0 milestone Mar 5, 2015
@ddomingues
Copy link
Contributor Author

@karianna Spec implemented.

@luisrudge
Copy link

@karianna Thoughts?

@wesleycho
Copy link
Contributor

Landed as e5f5f75, thanks for the work!

@luisrudge
Copy link

Is there a version with this already?

@wesleycho
Copy link
Contributor

It will be released when 0.13 is released - we are hoping to have it out by latest in a month. We are looking to address the main 1.3 compatibility issues currently for this release, as well as full integration with ngAnimate - both of these objectives are mostly complete.

@luisrudge
Copy link

Ok thanks!

Enviado pelo meu Windows Phone


From: Wesley Chomailto:[email protected]
Sent: ‎22/‎03/‎2015 23:08
To: angular-ui/bootstrapmailto:[email protected]
Cc: Luís Rudgemailto:[email protected]
Subject: Re: [bootstrap] Autofocus corrects the second time that the modal is open (#2945)

It will be released when 0.13 is released - we are hoping to have it out by latest in a month. We are looking to address the main 1.3 compatibility issues currently for this release, as well as full integration with ngAnimate - both of these objectives are mostly complete.


Reply to this email directly or view it on GitHub:
#2945 (comment)

@luisrudge
Copy link

Is this released yet?

@karianna
Copy link
Contributor

No

@luisrudge
Copy link

Thanks. Any ETA?

@rvanbaalen
Copy link
Contributor

@luisrudge You can keep an eye on https://github.com/angular-ui/bootstrap/releases if you want to stay up to date with the release cycle. No need to post comments unrelated to the issue.

@angular-ui angular-ui locked and limited conversation to collaborators Apr 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants