Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(modal): added support for autofocus fields on open #2377

Closed
wants to merge 1 commit into from

Conversation

nl5887
Copy link

@nl5887 nl5887 commented Jun 22, 2014

No description provided.

@marcalj
Copy link

marcalj commented Jun 24, 2014

Please merge this!!! :)

@klamping
Copy link

klamping commented Jul 9, 2014

👍

@wilg
Copy link

wilg commented Oct 10, 2014

Does this close #2802?

Looks like it has a conflict, also. @nl5887 Are you around to update this or should I open a new pull?

@cvrebert
Copy link
Contributor

X-Ref: twbs/bootstrap#12525

@wilg
Copy link

wilg commented Oct 13, 2014

Is there a way to use the shown.bs.modal event in angular-ui? I couldn't figure it out from the docs.

@nl5887
Copy link
Author

nl5887 commented Oct 13, 2014

Yes, I'm around. Will look at it today or tomorrow.

@nl5887
Copy link
Author

nl5887 commented Oct 17, 2014

Hmm, I think we can use the shown.bs.modal. Then angular-way will be to implement it in the directive.

@pkozlowski-opensource pkozlowski-opensource added this to the 0.12 milestone Oct 17, 2014
@nl5887
Copy link
Author

nl5887 commented Oct 20, 2014

If I interpret the jQuery Lite (https://docs.angularjs.org/api/ng/function/angular.element) correctly, it should be able to intercept the "shown.bs.modal" event. I'll implement this and submit to the pull request.

@pkozlowski-opensource
Copy link
Member

@nl5887 since we are not basing those directives on Bootstrap's CSS you will not see the shown.bs.modal fired....

@nl5887
Copy link
Author

nl5887 commented Oct 20, 2014

Right... Misread it. Would you like me to fire the events on open and close? This should work with jqLite only.

@pkozlowski-opensource
Copy link
Member

@nl5887 honestly I don't know what is the best solution for this issue at the moment. I'm not sure if an event would help here since you would have hard time figuring out when to send such an event, IMO.

@nl5887
Copy link
Author

nl5887 commented Oct 20, 2014

And what if I just fix the merge conflicts as it is was first? That should work and probably sufficient to fix the focus issues.

@wesleycho
Copy link
Contributor

I merged #2945, which should also address the original issue - thanks for the effort though!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants