-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat(modal): added support for autofocus fields on open #2377
Conversation
Please merge this!!! :) |
👍 |
X-Ref: twbs/bootstrap#12525 |
Is there a way to use the |
Yes, I'm around. Will look at it today or tomorrow. |
Hmm, I think we can use the shown.bs.modal. Then angular-way will be to implement it in the directive. |
If I interpret the jQuery Lite (https://docs.angularjs.org/api/ng/function/angular.element) correctly, it should be able to intercept the "shown.bs.modal" event. I'll implement this and submit to the pull request. |
@nl5887 since we are not basing those directives on Bootstrap's CSS you will not see the |
Right... Misread it. Would you like me to fire the events on open and close? This should work with jqLite only. |
@nl5887 honestly I don't know what is the best solution for this issue at the moment. I'm not sure if an event would help here since you would have hard time figuring out when to send such an event, IMO. |
And what if I just fix the merge conflicts as it is was first? That should work and probably sufficient to fix the focus issues. |
I merged #2945, which should also address the original issue - thanks for the effort though! |
No description provided.