This repository has been archived by the owner on May 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Investigate fixing the tab api #4836
Milestone
Comments
This was referenced Nov 7, 2015
Closed
Closed
wesleycho
changed the title
Investigate fixing the tab select/active api
Investigate fixing the tab api
Nov 7, 2015
I have fix for one of the issue, should I just creat a pr and refer to the item or should I try to fix all of them and creat one pr for all? |
Using one PR for each and referencing this issue is fine - we won't close the issue until all the checkboxes are addressed. We use the checkboxes in the description allow us to track progress separately and we've done this for other issues - adding the |
This was referenced Feb 1, 2016
@daniel-jann, #5720 was entered for this feature. |
icfantv
added a commit
to icfantv/bootstrap
that referenced
this issue
Mar 31, 2016
* add ability for user to prevent currently selected tab's deselction by calling `$event.preventDefault()` in tab's `deselect` callback. Fixes angular-ui#5720 Addresses angular-ui#2715, angular-ui#4836, and angular-ui#5716.
icfantv
added a commit
to icfantv/bootstrap
that referenced
this issue
Mar 31, 2016
* add ability for user to prevent currently selected tab's deselection by calling `$event.preventDefault()` in tab's `deselect` callback. Fixes angular-ui#5720 Addresses angular-ui#2715, angular-ui#4836, and angular-ui#5716.
icfantv
added a commit
that referenced
this issue
Mar 31, 2016
Here is a demonstration of being able to animate using the current api. Closing this as resolved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We need to make a breaking change to fix how the tab API is handled. It is a much more awkward component to use than the accordion, which allows for more use cases.
In particular, we have bugs against the select callback api, and the active state should be kept at a higher level since we can only have one tab active at any given time.
API needs to
event
into select callbackThe text was updated successfully, but these errors were encountered: