Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

First tab is not active if it its generated from data (ng-repeat) and followed by static tabs #3945

Closed
franciscoruiz opened this issue Jul 14, 2015 · 3 comments
Closed

First tab is not active if it its generated from data (ng-repeat) and followed by static tabs #3945

franciscoruiz opened this issue Jul 14, 2015 · 3 comments
Labels
component: tab type: bug
Milestone
1.0.0

Comments

@franciscoruiz
Copy link

Scenario

  • The first N tabs are generated from data, using ng-repeat.
  • Extra tabs are statically defined.

Expected behaviour

  • The first tab is active.

Actual behaviour

  • The first static tab is active.

http://plnkr.co/edit/Wf6ubHOhOQhcSHa9pk7I?p=preview
@wesleycho
Copy link
Contributor

Just to confirm, this looks like a current issue in master, as illustrated in this updated Plunker.

@wesleycho wesleycho added this to the 0.13.1 (Performance) milestone Jul 17, 2015
@wesleycho
Copy link
Contributor

This looks like a potentially difficult bug to fix - the tabs call tabsetCtrl.addTab(scope) on each tab directive compilation, and the tabs created with ng-repeat get created after the static version.

I will need to think on this.

@wesleycho wesleycho modified the milestones: 0.13.1 (npm), 0.13.2 (Performance) Jul 23, 2015
@wesleycho wesleycho modified the milestones: 0.13.2 (1.4 support), 0.13.3 (Performance) Aug 2, 2015
@wesleycho wesleycho modified the milestones: 0.13.3 (Fixes), 0.13.4 (Performance) Aug 9, 2015
@wesleycho wesleycho modified the milestones: 0.14.3, 0.14.2 Oct 14, 2015
@wesleycho wesleycho modified the milestones: 0.14.3, 1.0.0 Oct 23, 2015
@wesleycho
Copy link
Contributor

Closing in favor of #4836 - keep an eye out for that issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: tab type: bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@franciscoruiz @wesleycho