Remove node_modules from the checked-in files

[pkozlowski-opensource]

Based on #37

We need to get rid of the checked-in node modules but to do so we need a markdown dependency on the Google server.

[ajoslin]

Is there any way to find out what is available for the google server? I'm sure they have one of the gazillion markdown npm modules available there, but we just dunno which one.

[pkozlowski-opensource]

Had a chat with Igor yesterday and it looks like the node-markdown should be installed now. To be checked.

[pkozlowski-opensource]

OK, so it doesn't work :-(

The issue is that we've got no means of installing local modules and Grunt.js doesn't have means of referencing globally installed modules (unless you provide a full path), more info here: gruntjs/grunt#232

Hard-coding a path to globally installed modules wouldn't be that cool since it would probably break Travis and local builds. All in all I think that checked-in module is a reasonable compromise for now.

Going to close this issue for now, hopefully a better solution will emerge in the future...

[ajoslin]

We could save it in misc and require it there instead

Sent from my iPhone

On Jan 15, 2013, at 9:38 AM, Pawel Kozlowski [email protected] wrote:

OK, so it doesn't work :-(

The issue is that we've got no means of installing local modules and Grunt.js doesn't have means of referencing globally installed modules (unless you provide a full path), more info here: gruntjs/grunt#232

Hard-coding a path to globally installed modules wouldn't be that cool since it would probably break Travis and local builds. All in all I think that checked-in module is a reasonable compromise for now.

Going to close this issue for now, hopefully a better solution will emerge in the future...

—
Reply to this email directly or view it on GitHub.

[petebacondarwin]

We need to talk to Igor about this. When I suggested that we add a call to
npm install in the build he was worried about it accidentally running some
random code and laying waste to his server. It occurred to me that we can
already do this by writing dodgy stuff in our grunt.js file and that he
should be running each build inside some kind of sandbox (perhaps virtual
server) environment anyway.

On 15 January 2013 16:09, Andy Joslin [email protected] wrote:

We could save it in misc and require it there instead

Sent from my iPhone

On Jan 15, 2013, at 9:38 AM, Pawel Kozlowski [email protected]
wrote:

OK, so it doesn't work :-(

The issue is that we've got no means of installing local modules and
Grunt.js doesn't have means of referencing globally installed modules
(unless you provide a full path), more info here: gruntjs/grunt#232

Hard-coding a path to globally installed modules wouldn't be that cool
since it would probably break Travis and local builds. All in all I think
that checked-in module is a reasonable compromise for now.

Going to close this issue for now, hopefully a better solution will
emerge in the future...

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/41#issuecomment-12274494.