CI build fails

[pkozlowski-opensource]

The CI build we've got at Google fails now due to a missing npm module:

Loading "grunt.js" tasks and helpers...ERROR
>> Error: Cannot find module 'node-markdown'

We should either modify the build or change the module used.

[pkozlowski-opensource]

There are 2 PRs (dialog provider and accordion with animations) that I would like to merge before publishing a web site and cutting the o.1 release. But to merge them I need to make sure that the build is OK on all browsers and for this I need the CI working. So, if no one objects I'm going to look into it tight now and move the build back to green.

[petebacondarwin]

The problem is that the ci server does not run npm install and I could find
no way to configure that, unlike in Travis. I posted an email to
angular-dev regarding this.
Pete

... sent from my tablet
On 28 Dec 2012 19:12, "Pawel Kozlowski" [email protected] wrote:

There are 2 PRs (dialog provider and accordion with animations) that I
would like to merge before publishing a web site and cutting the o.1
release. But to merge them I need to make sure that the build is OK on all
browsers and for this I need the CI working. So, if no one objects I'm
going to look into it tight now and move the build back to green.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/37#issuecomment-11739043.

[pkozlowski-opensource]

Yes, I know... The ultimate solution is to reconfigure the CI (either add required modules globally or add the install step as you've suggested) but I want to unblock the situation for now. There are number of cool PRs waiting and the demo site is long overdue.

What I'm planning to do for now is to check-in node modules and remove them as soon as we sort out the CI issues. The other idea would be to remove markdown generation but I would really like to publish the demo site...

[petebacondarwin]

This is a nasty work around but it'll do for now.
:-)

... sent from my tablet
On 28 Dec 2012 20:37, "Pawel Kozlowski" [email protected] wrote:

Yes, I know... The ultimate solution is to reconfigure the CI (either add
required modules globally or add the install step as you've suggested) but
I want to unblock the situation for now. There are number of cool PRs
waiting and the demo site is long overdue.

What I'm planning to do for now is to check-in node modules and remove
them as soon as we sort out the CI issues. The other idea would be to
remove markdown generation but I would really like to publish the demo
site...

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/37#issuecomment-11740994.

[boneskull]

Just wanted to tell you all what a great job you are doing.

Chris

On Dec 28, 2012, at 12:37 PM, Pawel Kozlowski [email protected] wrote:

Yes, I know... The ultimate solution is to reconfigure the CI (either add required modules globally or add the install step as you've suggested) but I want to unblock the situation for now. There are number of cool PRs waiting and the demo site is long overdue.

What I'm planning to do for now is to check-in node modules and remove them as soon as we sort out the CI issues. The other idea would be to remove markdown generation but I would really like to publish the demo site...

—
Reply to this email directly or view it on GitHub.

[pkozlowski-opensource]

OK, so I've checked in the markdown npm module, did some other minor fixes and now CI is back. Moreover the demo site is being generated on each build and we can see it in action on the CI server:

http://ci.angularjs.org/job/angularui-bootstrap/ws/dist/index.html

Going to open a PR with those small fixes and if no-one objects I'm going to merge it so I can start reviewing and merging PRs.

@ajoslin Andy, you did awesome job putting together this demo site skeleton, it gives us structure to work with! We need to add docs for the remaining directives, add more info etc. but this is a good start!

[pkozlowski-opensource]

Temporary fix done in e284cde. Going to open another issue for a proper fix.