Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Commit

Permalink
chore(dropdown): fix accidental deletion
Browse files Browse the repository at this point in the history
  • Loading branch information
@wesleycho
wesleycho committed Nov 30, 2016
1 parent c824731 commit a4d7076
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/dropdown/dropdown.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ angular.module('ui.bootstrap.dropdown', ['ui.bootstrap.multiMap', 'ui.bootstrap.

scope.focusToggleElement();
uibDropdownService.open(scope, $element, appendTo);
} else
} else {
if (self.dropdownMenuTemplateUrl) {
if (templateScope) {
templateScope.$destroy();
Expand Down

2 comments on commit a4d7076

@agorer
Copy link

@agorer agorer commented on a4d7076 Dec 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing the line uibDropdownService.close(scope, $element, appendTo); after the else. Was removed on previous commit and it is causing some problems (on-toggle function not being called and after you open and appendToOpenClass not being appended to body after the first time you open and close the dropdown).

@agorer
Copy link

@agorer agorer commented on a4d7076 Dec 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a PR for it.

Please sign in to comment.