Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Commit

Permalink
revert(dropdown): undo addition of unbind
Browse files Browse the repository at this point in the history
  • Loading branch information
wesleycho committed Nov 30, 2016
1 parent 1653afa commit c824731
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/dropdown/dropdown.js
Original file line number Diff line number Diff line change
Expand Up @@ -336,9 +336,7 @@ angular.module('ui.bootstrap.dropdown', ['ui.bootstrap.multiMap', 'ui.bootstrap.

scope.focusToggleElement();
uibDropdownService.open(scope, $element, appendTo);
} else {
$document.off('keydown', uibDropdownService.keybindFilter);
uibDropdownService.close(scope, $element, appendTo);
} else
if (self.dropdownMenuTemplateUrl) {
if (templateScope) {
templateScope.$destroy();
Expand Down

2 comments on commit c824731

@vukers
Copy link

@vukers vukers commented on c824731 Dec 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 341 should not have been deleted, only 340.
The removal of uibDropdownService.close(scope, $element, appendTo); is causing other elements on the page to not be focusable.

@imrvelj
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Please sign in to comment.