-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fromEvent): add FromEvent type export #19
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c33522b
feat(fromEvent): add FromEvent type export
huan 10d6195
feat(fromEvent): add README docs
huan 4cbc27b
Let's not bump the version just yet
andywer c1f4607
feat(fromEvent): rename rxjsFromEvent -> rxFromEvent for friendlier
huan e581f3a
Merge branch 'from-event' of github.com:huan/typed-emitter into from-…
huan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
/** | ||
* devanshj/rxjs-from-emitter#4 - typed-emitter compatibility | ||
* | ||
* @see https://github.com/devanshj/rxjs-from-emitter/issues/4#issuecomment-665104646 | ||
*/ | ||
/* eslint-disable no-use-before-define */ | ||
import { | ||
fromEvent as rxjsFromEvent, | ||
Observable, | ||
} from 'rxjs' | ||
import type TypedEventEmitter from 'typed-emitter' | ||
|
||
type ObservedValue<A extends unknown[]> = | ||
A['length'] extends 0 ? void : | ||
A['length'] extends 1 ? A[0] : | ||
A | ||
|
||
interface FromTypedEvent { | ||
< Emitter extends TypedEventEmitter<any> | ||
, EventName extends keyof Events | ||
, Events = Emitter extends TypedEventEmitter<infer T> ? T : never | ||
>(emitter: Emitter, event: EventName): Observable<ObservedValue<Events[EventName] extends (...args: infer A) => any ? A : never>> | ||
} | ||
|
||
export type FromEvent = FromTypedEvent & typeof rxjsFromEvent |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
// https://github.com/octokit/openapi-types.ts/issues/16#issuecomment-772784156 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really tiny suggestion:
rxjsFromEvent
is quite a handful. What would you think about renaming the import alias torxFromEvent
?It's just two letters difference, but I think it would make the code feel "friendlier".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely agree with this.
Have renamed
rxjsFromEvent
torxFromEvent
from both the README and the source code.