-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fromEvent): add FromEvent type export #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Haven't tested it yet, but looks good.
I only reverted the version bump as a best practice (imagine having three open PRs and each bumping the version while you aren't even sure they will be released together)
README.md
Outdated
This can be fixed by the following code, by replacing the `fromEvent` type with our enhanced one: `FromEvent`: | ||
|
||
```ts | ||
import { fromEvent as rxjsFromEvent } from "rxjs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really tiny suggestion: rxjsFromEvent
is quite a handful. What would you think about renaming the import alias to rxFromEvent
?
It's just two letters difference, but I think it would make the code feel "friendlier".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely agree with this.
Have renamed rxjsFromEvent
to rxFromEvent
from both the README and the source code.
Great to know that you think this PR is good! I have followed your suggestion and finished the modifications. Please let me know if there's any other suggestion so we can continue improving it, and I'm looking forward to installing this feature from NPM! (before the |
@huan Cool. I'm just thinking what the next steps are. How about this: Let's already publish a pre-release version to npm ( Btw, I didn't quite get this bit:
|
Thanks, publishing a pre-release version to npm as
The
I don't know if the RxJS team has already a better solution for this, but for now, it's the only one I can use. |
@huan Sorry for the delay! Published commit e581f3a as |
I have used it and everything working as expected so far: Thank you very much for publishing this new feature! |
This PR tries to implement the discussion from #9