Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed suppression for plugin applications with alias #686

Conversation

gururani-abhishek
Copy link
Contributor

closes #654

  1. In Gradle 8.1, this workaround will no longer be necessary.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1. In Gradle 8.1, this workaround was no longer necessary.
@google-cla
Copy link

google-cla bot commented Apr 25, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mmoczkowski mmoczkowski self-requested a review April 25, 2023 14:41
@alexvanyo
Copy link
Contributor

The update to AGP 8.1 was merged, so this PR should be mergable now on top of main once the conflicts are resolved.

@gururani-abhishek
Copy link
Contributor Author

The update to AGP 8.1 was merged, so this PR should be mergable now on top of main once the conflicts are resolved.

Resolved conflicts :)

@gururani-abhishek
Copy link
Contributor Author

Found something related to this build fail : google/protobuf-gradle-plugin#687

@rosejr
Copy link
Contributor

rosejr commented Apr 28, 2023

Thanks for the PR; this has been done in #667

@rosejr rosejr closed this Apr 28, 2023
@gururani-abhishek gururani-abhishek deleted the cleanup-suppression-for-plugin-applications-with-alias branch April 30, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cleanup] Remove suppression for plugin applications with alias once updated to Gradle 8.1
3 participants