Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Remove suppression for plugin applications with alias once updated to Gradle 8.1 #654

Closed
3 tasks done
alexvanyo opened this issue Apr 7, 2023 · 3 comments · Fixed by #667
Closed
3 tasks done

[Cleanup] Remove suppression for plugin applications with alias once updated to Gradle 8.1 #654

alexvanyo opened this issue Apr 7, 2023 · 3 comments · Fixed by #667
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alexvanyo
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Is there a StackOverflow question about this issue?

  • I have searched StackOverflow

What happened?

#35 added suppression for using the alias to apply plugins from libs.versions.toml.

In Gradle 8.1, this workaround is no longer necessary: https://docs.gradle.org/8.1-rc-1/userguide/upgrading_version_8.html#kotlin_dsl_plugins_catalogs_workaround

Once we update to Gradle 8.1, we'll be able to remove those suppressions.

Relevant logcat output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@alexvanyo alexvanyo added enhancement New feature or request good first issue Good for newcomers labels Apr 7, 2023
@SimonMarquis SimonMarquis mentioned this issue Apr 18, 2023
Merged
@gururani-abhishek
Copy link
Contributor

Hey @alexvanyo, can I work on this?

@alexvanyo
Copy link
Contributor Author

Definitely, happy to review a PR once we've updated to Gradle 8.1

@gururani-abhishek gururani-abhishek mentioned this issue Apr 25, 2023
Closed
@gururani-abhishek
Copy link
Contributor

Hey @alexvanyo this is my first contribution here, would love to contribute more :)
Are there any other issues that I can work on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@alexvanyo @gururani-abhishek