Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force JavaVersion.VERSION_1_7 for all samples #91

Merged
merged 2 commits into from
Sep 3, 2015

Conversation

proppy
Copy link
Contributor

@proppy proppy commented Sep 3, 2015

With:

for f in */app/build.gradle; do sed -e $'s/^.*android.ndk/\
    compileOptions.with {\
        sourceCompatibility=JavaVersion.VERSION_1_7\
        targetCompatibility=JavaVersion.VERSION_1_7\
    }\
\
&/' $f; done

Closes #43

@tjohns
Copy link
Contributor

tjohns commented Sep 3, 2015

I approve of this change 👍.

I wonder if we should do this with the rest of the framework samples...

@proppy
Copy link
Contributor Author

proppy commented Sep 3, 2015

@ggfan changed the SDL syntax as you suggested.

@proppy proppy assigned ggfan and unassigned claywilkinson Sep 3, 2015
@ggfan
Copy link
Contributor

ggfan commented Sep 3, 2015

LGTM, thanks!

proppy added a commit that referenced this pull request Sep 3, 2015
force JavaVersion.VERSION_1_7 for all samples
@proppy proppy merged commit 567f68c into android:master Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants