Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build error for hello-jni project. #43

Closed
wants to merge 1 commit into from

Conversation

ok3141
Copy link

@ok3141 ok3141 commented Jul 26, 2015

Applied changes from issue #34

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ok3141
Copy link
Author

ok3141 commented Jul 26, 2015

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@proppy
Copy link
Contributor

proppy commented Aug 3, 2015

Sorry for the late followup, I was in vacation, and thanks for your contribution!

Note that another way to "fix" this is to point to another version of java in "Project Structure", see also #44 for yet another workaround.

I think it's OK to have (temporary?) workarounds in our samples, but a real bug should also be filed thru https://code.google.com/p/android/issues/entry?template=Tools%20bug%20report about the wrong version of java being selected by default by Android Studio.

We should probably file the issue first and reference it as a comment in build.gradle.

In the meantime can you rebase the change, and split the .gitignore and api bump in separate PR? so we can apply and review them separately.

Thanks in advance.

@proppy
Copy link
Contributor

proppy commented Sep 3, 2015

This is fixed on all samples with #91, thanks for raising this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants