-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sensor graph sample #51
Conversation
buildToolsVersion = "22.0.1" | ||
|
||
defaultConfig.with { | ||
applicationId = "com.android.gl2jni" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/gl2jni/sensorgraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@ggfan @hak @claywilkinson @gguuss does someone have the bandwidth to review this? |
just a few comment:
|
@ggfan feel free to comment directly on the code too.
Done. |
You mean I should delete them with glDeleteShader after calling glLinkProgram? If hello-gl2 has also this problem, we should probably fix it too.
You're right I will update the sample to delete the shader after linking |
I'm just using the default |
@ggfan Done. |
PTAL |
LGTM |
Travis is green, merging. |
Sensor graph is a C++ Android sample that read current accelerometer values and draw them using OpenGL.
It demonstrate usage of the following Native C++ API:
/cc @ggfan @hak