Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug while using other home pages #9

Merged
merged 3 commits into from
Oct 14, 2023
Merged

Fix bug while using other home pages #9

merged 3 commits into from
Oct 14, 2023

Conversation

FoskyM
Copy link
Contributor

@FoskyM FoskyM commented Oct 9, 2023

Snipaste_2023-10-09_16-34-47
Snipaste_2023-10-09_16-38-20

While using other page as homepage, these two button will be conflicting so it need to do some judgments.
Just as follow:
Snipaste_2023-10-09_16-38-49

@rafaucau rafaucau self-requested a review October 9, 2023 10:49
@rafaucau rafaucau self-assigned this Oct 9, 2023
@rafaucau rafaucau added the bug Something isn't working label Oct 9, 2023
rafaucau
rafaucau requested changes Oct 14, 2023
View reviewed changes
Copy link
Member

@rafaucau rafaucau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the translations, it looks ok.

js/src/forum/components/MobileTab.tsx Outdated Show resolved Hide resolved
rafaucau
rafaucau reviewed Oct 14, 2023
View reviewed changes
locale/zh-Hans.yml Outdated Show resolved Hide resolved
rafaucau
rafaucau requested changes Oct 14, 2023
View reviewed changes
Copy link
Member

@rafaucau rafaucau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations other than English should be added to the language packs via Weblate.

@rafaucau rafaucau merged commit dbf631d into android-com-pl:master Oct 14, 2023
1 check failed
@rafaucau
Copy link
Member

Released 1.3.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaucau rafaucau rafaucau requested changes

Assignees

@rafaucau rafaucau

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FoskyM @rafaucau