Merge cockroachdb#123820

123820: roachtest: turn on DistSender circuit breakers for failover chaos tests r=nicktrav,andrewbaptist a=arulajmani Failover chaos tests create asymetric partitions where DistSender circuit breakers are useful. It prevents failure modes such as cockroachdb#123736 (comment). Fixes cockroachdb#123736 Release note: None Co-authored-by: Arul Ajmani <[email protected]>
andrewbaptist · May 10, 2024 · 6e1b82d · 6e1b82d
2 parents 16d4175 + b66922d
commit 6e1b82d
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/pkg/cmd/roachtest/tests/failover.go b/pkg/cmd/roachtest/tests/failover.go
@@ -213,6 +213,11 @@ func runFailoverChaos(ctx context.Context, t test.Test, c cluster.Cluster, readO
 	settings.Env = append(settings.Env, "COCKROACH_ENABLE_UNSAFE_TEST_BUILTINS=true")
 	settings.Env = append(settings.Env, "COCKROACH_SCAN_MAX_IDLE_TIME=100ms") // speed up replication
 
+	// DistSender circuit breakers are useful for these chaos tests. Turn them on.
+	// TODO(arul): this can be removed if/when we turn on DistSender circuit
+	// breakers for all ranges by default.
+	settings.ClusterSettings["kv.dist_sender.circuit_breakers.mode"] = "all ranges"
+
 	m := c.NewMonitor(ctx, c.Range(1, 9))
 
 	failers := []Failer{}