roachtest: turn on DistSender circuit breakers for failover chaos tests #123820
Conversation
arulajmani
requested review from
herkolategan and
DarrylWong
and removed request for
a team
|
This change is |
arulajmani
added
the
backport-24.1.x
There was a problem hiding this comment.
Thanks!
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @arulajmani, @DarrylWong, and @herkolategan)
-- commits line 4 at r1:
nit: assymetric -> asymmetric
pkg/cmd/roachtest/tests/failover.go line 211 at r1 (raw file):
rng, _ := randutil.NewTestRand() // Create cluster, and set up failures for all failure modes.
nit: I'm not sure you should make this change. While failers is technically not a word, this is referring to the Failer type which is used a few lines below. I think the previous wording was slightly better. I don't mind too much either way.
pkg/cmd/roachtest/tests/failover.go line 216 at r1 (raw file):
settings.Env = append(settings.Env, "COCKROACH_SCAN_MAX_IDLE_TIME=100ms") // speed up replication // DistSender circuit breakers are useful for these chaos tests. Turn them on.
nit: consider adding a TODO either here or in the definition of the variable to remove this if we later make this the default.
Failover chaos tests create asymetric partitions where DistSender circuit breakers are useful. It prevents failure modes such as cockroachdb#123736 (comment). Fixes cockroachdb#123736 Release note: None
There was a problem hiding this comment.
TFTRs!
bors r=nicktrav,andrewbaptist
Reviewable status:
Previously, andrewbaptist (Andrew Baptist) wrote…
nit: assymetric -> asymmetric
Done.
pkg/cmd/roachtest/tests/failover.go line 211 at r1 (raw file):
Previously, andrewbaptist (Andrew Baptist) wrote…
nit: I'm not sure you should make this change. While failers is technically not a word, this is referring to the
Failertype which is used a few lines below. I think the previous wording was slightly better. I don't mind too much either way.
I see, I thought it was a typo. I've reverted.
pkg/cmd/roachtest/tests/failover.go line 216 at r1 (raw file):
Previously, andrewbaptist (Andrew Baptist) wrote…
nit: consider adding a TODO either here or in the definition of the variable to remove this if we later make this the default.
Done.
|
Build failed: |
|
bors retry |
Failover chaos tests create asymetric partitions where DistSender circuit breakers are useful. It prevents failure modes such as #123736 (comment).
Fixes #123736
Release note: None