Default Unit #15
Default Unit #15
Conversation
|
@lenards no rush or pressure but would be awesome if you could take a look at this one |
There was a problem hiding this comment.
I think this works out really well! 🎉
It's a good move to simplify 🙇
I was tempted to think of a name to alias (Millis -> Millis) functions to ... but that likely obscures what they are (and would make it more difficult to see that I could define my own - if I wanted). So I - perhaps - should I have omitted that 😉. Just sharing on the off-chance you had a similar thought.
| @@ -9,14 +9,18 @@ | |||
| "devDependencies": { | |||
| "ava": "^3.15.0", | |||
| "elm": "^0.19.1-5", | |||
| "elm-doc-preview": "^5.0.5", | |||
There was a problem hiding this comment.
I hadn't checked this library out until recently. It's pretty cool.
There was a problem hiding this comment.
I only discovered it recently, it's a really nice feedback loop when you're working on a library!
| -} | ||
| hours : Millis -> Millis | ||
| hours millis = | ||
| minutes millis * 60 |
There was a problem hiding this comment.
I think this works out really, really well.
|
That's a good idea for aliasing |
|
That’s a perfect name! 🙌
…On Mon, Mar 1, 2021 at 1:39 AM Andrew MacMurray ***@***.***> wrote:
That's a good idea for aliasing Millis -> Millis, maybe ToUnit?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAABOI7QMWROYNFUNA5G6UDTBNHELANCNFSM4YJ4J72A>
.
|
|
Gonna merge this in now, thanks for your help @lenards! |
Resolves #8