Default unit

[andrewMacmurray]

Curious if anyone is using a mixture of TimeUnits? Was thinking about changing the api to have a default unit of milliseconds so it's a little cleaner:

Delay.after 500 SomethingTriggered

Delay.sequence
    [ ( 100, MsgOne )
    , ( 200, MsgTwo )
    , ( 100, MsgThree )
    ]

And maybe add some helpers to convert millis to other time units:

Delay.after (Delay.seconds 5) SomethingTriggered

seconds : Millis -> Millis
seconds millis =
    1000 * millis

@lenards given you've been using this recently do you have any thoughts?

[alenards]

I have tended to use only one TimeUnit and that's usually milliseconds.

I do like the idea of the Delay.seconds so it's clear at the "call site" what units are being used.

I would be down to take a crack at doing the helpers if you'd like.

[andrewMacmurray]

That's good to know, thanks @alenards. I was planning on doing the cleanups this weekend but would be good to get some feedback / review from you if that's cool?

[lenards]

DEFINITELY!! I would love to get look over changes and offer any thoughts/notes.

…

On Fri, Feb 26, 2021 at 4:48 AM Andrew MacMurray ***@***.***> wrote: That's good to know, thanks @alenards <https://github.com/alenards>. I was planning on doing the cleanups this weekend but would be good to get some feedback / review from you if that's cool? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAABOI5LCLXVLSRT6AU37CTTA6DA3ANCNFSM4YE7KTVQ> .