Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table format object #586

Merged
merged 1 commit into from
Oct 24, 2021
Merged

Add table format object #586

merged 1 commit into from
Oct 24, 2021

Conversation

wagoodman
Copy link
Contributor

This is a follow up from #578

Continues on with the format pattern introduced in #550 with the table format. This is the same implementation that existed with the presenters (does not support any additional capabilities such as decoding or validation).

@wagoodman wagoodman requested a review from a team October 22, 2021 22:10
@wagoodman wagoodman self-assigned this Oct 22, 2021
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                   old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2          1.36ms ± 1%    1.30ms ± 7%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2        2.84ms ± 8%    2.49ms ± 9%  -12.46%  (p=0.016 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     831µs ± 3%     731µs ± 2%  -12.04%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 871µs ± 3%     747µs ± 4%  -14.26%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  875µs ± 3%     777µs ± 9%  -11.17%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  11.8ms ± 3%    10.4ms ± 3%  -11.68%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                 1.16ms ± 2%    1.05ms ± 8%   -9.58%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2       684ns ± 1%     632ns ± 6%   -7.67%  (p=0.008 n=5+5)

name                                                   old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           225kB ± 0%     225kB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2         973kB ± 0%     973kB ± 0%   +0.05%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     190kB ± 0%     190kB ± 0%   +0.16%  (p=0.016 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 208kB ± 0%     209kB ± 0%   +0.19%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  215kB ± 0%     215kB ± 0%   +0.00%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  3.11MB ± 0%    3.11MB ± 0%   -0.15%  (p=0.032 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                 1.25MB ± 0%    1.25MB ± 0%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2        336B ± 0%      336B ± 0%     ~     (all equal)

name                                                   old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           5.37k ± 0%     5.37k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2         17.9k ± 0%     17.9k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     4.71k ± 0%     4.71k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                 5.44k ± 0%     5.44k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                  6.13k ± 0%     6.13k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                   51.1k ± 0%     51.1k ± 0%     ~     (p=0.730 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  5.40k ± 0%     5.40k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2        9.00 ± 0%      9.00 ± 0%     ~     (all equal)

@wagoodman wagoodman merged commit fb588ff into main Oct 24, 2021
@wagoodman wagoodman deleted the add-table-format branch October 24, 2021 12:09
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants