-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPDX JSON format object #584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Test ResultsBenchmark results from the latest changes vs base branch
|
6 tasks
luhring
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Treat all comments as "nit"!
(Another general "nit" for consideration would be to consider more use of vertical space to visually separate if/switch blocks, variable decls, and return statements.)
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
force-pushed
the
add-spdxjson-format-lossy
branch
from
October 29, 2021 14:33
6ad50c2
to
2433d60
Compare
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
* remove existing spdxjson presenter + helpers Signed-off-by: Alex Goodman <[email protected]> * add new spdx22json format Signed-off-by: Alex Goodman <[email protected]> * add common sdpxhelpers (migrated) Signed-off-by: Alex Goodman <[email protected]> * use new common spdx helpers Signed-off-by: Alex Goodman <[email protected]> * wire up new spdx22json format object Signed-off-by: Alex Goodman <[email protected]> * remove lossless syft-specific property bags Signed-off-by: Alex Goodman <[email protected]> * remove spdxjson decoder and validator Signed-off-by: Alex Goodman <[email protected]> * add nil checks in spdx test helpers Signed-off-by: Alex Goodman <[email protected]> * remove empty default case Signed-off-by: Alex Goodman <[email protected]> * use explicit golden snapshot Signed-off-by: Alex Goodman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from #578
Continues on with the format pattern introduced in #550 with the
spdx22json
format. This is the same implementation that existed with the presenters, but does not support any additional capabilities (decoding or validation).Additional work also done: