Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nirila review PR #5

Closed
wants to merge 219 commits into from
Closed

nirila review PR #5

wants to merge 219 commits into from

Conversation

anatawa12
Copy link
Owner

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

niwaniwa and others added 30 commits March 7, 2023 04:43
add action file
Change trigger timing
* feat: hide image easily

* docs(changelog): add 画像を動画と同様に簡単に隠せるように

Cherry-picks: dc87632
* feat: フォローやお気に入り登録をしていないチャンネルを開く時は概要ページを開くように

* Update CHANGELOG.md

---------

Co-authored-by: tamaina <[email protected]>
Cherry-picks: 239ea39
* feat: add edit antenna button onto deck column

* feat: add edit list button onto deck column

* docs(changelog): add deck UIのカラムのメニューからアンテナとリストの編集画面を開けるようになりました

Cherry-picks: 1ab9f09
* chore(frontend): 自分のnoteのrenoteも省略するように

Co-authored-by: madorama <[email protected]>

* docs(changelog): add 見たことのあるRenoteを省略して表示をオンのときに自分のnoteのrenoteを省略するように

---------

Co-authored-by: madorama <[email protected]>
Cherry-picks: 2606167
…1211)

* fix: change tapAction of photoswipe to 'close'

* doc: update CHANGELOG.md

---------

Co-authored-by: tamaina <[email protected]>
Cherry-pics: 63e21a4
Copy link

github-actions bot commented Nov 24, 2023

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -1,7 +1,7 @@
 {
   "openapi": "3.0.0",
   "info": {
-    "version": "2023.11.1",
+    "version": "2023.11.1-kinel.1",
     "title": "Misskey API",
     "x-logo": {
       "url": "/static-assets/api-doc.png"
@@ -37342,16 +37342,24 @@
                   "on": {
                     "type": "array",
                     "items": {
-                      "type": "string",
-                      "enum": [
-                        "mention",
-                        "unfollow",
-                        "follow",
-                        "followed",
-                        "note",
-                        "reply",
-                        "renote",
-                        "reaction"
+                      "oneOf": [
+                        {
+                          "type": "string",
+                          "enum": [
+                            "mention",
+                            "unfollow",
+                            "follow",
+                            "followed",
+                            "note",
+                            "reply",
+                            "renote",
+                            "reaction"
+                          ]
+                        },
+                        {
+                          "type": "string",
+                          "pattern": "^note@[a-zA-Z0-9]{1,20}$"
+                        }
                       ]
                     }
                   }
@@ -37386,6 +37394,15 @@
                       }
                     }
                   },
+                  "ADMIN_WEBHOOK_DENIED": {
+                    "value": {
+                      "error": {
+                        "message": "You cannot create webhook for other users.",
+                        "code": "ADMIN_WEBHOOK_DENIED",
+                        "id": "0d3321b1-6f66-41aa-9fbe-233c60ce19b0"
+                      }
+                    }
+                  },
                   "INVALID_PARAM": {
                     "value": {
                       "error": {
@@ -37830,16 +37847,24 @@
                   "on": {
                     "type": "array",
                     "items": {
-                      "type": "string",
-                      "enum": [
-                        "mention",
-                        "unfollow",
-                        "follow",
-                        "followed",
-                        "note",
-                        "reply",
-                        "renote",
-                        "reaction"
+                      "oneOf": [
+                        {
+                          "type": "string",
+                          "enum": [
+                            "mention",
+                            "unfollow",
+                            "follow",
+                            "followed",
+                            "note",
+                            "reply",
+                            "renote",
+                            "reaction"
+                          ]
+                        },
+                        {
+                          "type": "string",
+                          "pattern": "^note@[a-zA-Z0-9]{1,20}$"
+                        }
                       ]
                     }
                   },
@@ -37879,6 +37904,15 @@
                       }
                     }
                   },
+                  "UPDATE_ADMIN_WEBHOOK_DENIED": {
+                    "value": {
+                      "error": {
+                        "message": "You cannot create webhook for other users.",
+                        "code": "UPDATE_ADMIN_WEBHOOK_DENIED",
+                        "id": "eb43c0c4-24a3-487d-b139-f3e4e58f87a4"
+                      }
+                    }
+                  },
                   "INVALID_PARAM": {
                     "value": {
                       "error": {
@@ -56456,6 +56490,10 @@
                   "excludeNsfw": {
                     "type": "boolean",
                     "default": false
+                  },
+                  "includeSensitiveChannel": {
+                    "type": "boolean",
+                    "default": false
                   }
                 },
                 "required": [

Get diff files from Workflow Page

<p v-if="appearNote.cw != null" :class="$style.cw">
<Mfm v-if="appearNote.cw != ''" style="margin-right: 8px;" :text="appearNote.cw" :author="appearNote.user" :nyaize="'respect'"/>
<p v-if="cwExists" :class="$style.cw">
<Mfm v-if="appearNote.cw != ''" style="margin-right: 8px;" :text="appearNote.cw ?? '<small>' + i18n.ts.sensitiveChannelAutoCW + '</small>'" :author="appearNote.user" :nyaize="'respect'"/>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

もう少しマシな書き方あると思うので後でやる

@anatawa12 anatawa12 closed this Nov 26, 2023
@anatawa12 anatawa12 deleted the merge-2023.11.1 branch November 26, 2023 14:30
anatawa12 pushed a commit that referenced this pull request May 9, 2024
anatawa12 pushed a commit that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants