fix(frontend): 画面ビューワをタップした場合、マウスクリックと同様に画像ビューワを閉じるように #11211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #11211 +/- ##
===========================================
- Coverage 77.70% 77.70% -0.01%
===========================================
Files 908 908
Lines 91750 91758 +8
Branches 7670 7672 +2
===========================================
+ Hits 71295 71296 +1
- Misses 20455 20462 +7
|
tamaina
changed the title
|
👍 👍👍👍 |
anatawa12
pushed a commit
to anatawa12/misskey
that referenced
this pull request
Jul 13, 2023
…1211) * fix: change tapAction of photoswipe to 'close' * doc: update CHANGELOG.md --------- Co-authored-by: tamaina <[email protected]> Cherry-pics: 63e21a4
slofp
pushed a commit
to Secineralyr/misskey.dream
that referenced
this pull request
Jul 21, 2023
…1211) * fix: change tapAction of photoswipe to 'close' * doc: update CHANGELOG.md --------- Co-authored-by: tamaina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
スマホ版のWebページでノート内の画像表示をクローズする操作が変わります。
以前は、クローズボタンまたはスワイプのみでクローズしていました。
以後は、画像または画像外の領域をタップすることでもクローズできるようになります。
Why
画像表示モードのクローズに関して、PC版と大きくUXが異なっていました。
このPRによりPC版とスマホ版が同様のUXになります。
Additional info (optional)
Issue
#11210
テスト観点
実際に操作を行なって、UIの動作に問題がないか確認する必要があります。
Checklist