-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs improvements #961
Docs improvements #961
Conversation
…pe weight for preview when toggled
2b86240
to
3491f16
Compare
d7e035b は別のレビュー中に気付いて気になったので直しました |
Animator Optimizer、何するというのが結構説明が重いのでどこで説明しようってことになる |
量が多いなら ページ分けも考えてみましたが、現段階ではややこしくなるだけかも |
節分けるか |
# Conflicts: # CHANGELOG-PRERELEASE.md
71df3e2
to
7f1efca
Compare
ready for reviewのつもりです (reviewされてないので再requestはできない状態になってる) |
絶賛レビュー中です |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
部分レビュー
.docs/content/docs/reference/remove-mesh-by-blendshape/index.ja.md
Outdated
Show resolved
Hide resolved
.docs/content/docs/reference/remove-mesh-by-blendshape/index.md
Outdated
Show resolved
Hide resolved
review request: d2a1215 |
faqのmaterial slot animationの話書きました |
細かな改行周りはapplyされてリリースされてから確認して直すかも |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github sponsors とか boothとか、[]で囲ってあるやつのcapitalize確認してなかったなぁとなっています…どうしよう
Co-authored-by: Sayamame-beans <[email protected]>
Co-authored-by: Sayamame-beans <[email protected]>
同じキーが2つ…? (en未確認) AvatarOptimizer/Localization/ja-jp.po Lines 96 to 100 in ae09b65
|
(#961 (comment) はanatawaさんにどうなってるか聞かないと分かんないです…) |
|
…imize-component to top
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be last review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be the last review
Co-authored-by: Sayamame-beans <[email protected]>
Co-authored-by: Sayamame-beans <[email protected]>
Co-authored-by: Sayamame-beans <[email protected]>
Co-authored-by: Sayamame-beans <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final last review?
|
||
In some bugs, fixing them may change the behavior of the component widely.\ | ||
To fix such bugs, we usually add new flag to enable the new behavior.\ | ||
By making the flag disabled by default for existing components, we keep the behavior of the existing components and by making the flag enabled by default for newly added components, we fix the bug for new components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
上でalready added componentになってたけど、揃える?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for new components →newly added components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
両方揃えたほうが良さそうかな
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By making the flag disabled by default for existing components, we keep the behavior of the existing components and by making the flag enabled by default for newly added components, we fix the bug for new components. | |
By making the flag disabled by default for already added components, we keep the behavior of the existing components and by making the flag enabled by default for newly added components, we fix the bug for newly added components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
であれば、
By making the flag disabled by default for existing components, we keep the behavior of the existing components and by making the flag enabled by default for newly added components, we fix the bug for new components. | |
By making the flag disabled by default for already added components, we keep the behavior of already added components and by making the flag enabled by default for newly added components, we fix the bug for newly added components. |
Co-authored-by: Sayamame-beans <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #544
Fixes #891
Fixes #655
Fixes #765
Fixes #537
Fixes #814
Fixes #947
TODOs after applying suggestions