Relax limits about normals #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatawa12
added
the
improvement
Sayamame-beans
requested changes
Oct 11, 2023
Co-authored-by: Sayamame-beans <[email protected]>
Co-authored-by: Sayamame-beans <[email protected]>
|
英語は統合対象がmeshで設定対象がmodel、日本語は両方モデル、で良いんですかね…? (日本語の統合対象もメッシュ表記するべきな気がしています) |
|
suggest出すので、何か意図があったらignoreしてください |
Co-authored-by: Sayamame-beans <[email protected]>
Sayamame-beans
approved these changes
Oct 11, 2023
|
AutoFix考えたんだけどMergeSkinnedMeshをmergeしてる時とか、MAのRetargetあとであることとか考えるとすごく大変だったので見送った。issueは書いたほうが良さそうかも...? |
|
あー…なるほど、処理前(コンポーネント設定時)validationを行うようにして、かつその範疇で該当があれば出来るかもしれないけど…ぐらいの感じですかね? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalがあるモデルに対しては一切動作変更なし。
Fix #272