Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply modified properties before draw custom editor #221

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

hitsub
Copy link
Contributor

@hitsub hitsub commented Jun 13, 2023

Fix #220

MergePhysBoneEditorModificationUtils.DoProcess() 内でserializedObjectからプロパティを取得する前にプロパティの保存をしていないようです。
そのため、マージしたいPhysBoneをD&Dしてきても何も起きてないように見える現象が起きます。

描画前にApplyしてしまえば問題なさそうでしたので、draw custom editorの直前でApplyすることで修正しました。
もし他の手段で修正中などであればCloseしていただいて問題ないです。

@anatawa12 anatawa12 changed the base branch from master to master-0.4 June 13, 2023 11:39
@anatawa12
Copy link
Owner

根本の原因が確認できたため別途対処します。

@anatawa12 anatawa12 closed this Jun 13, 2023
@anatawa12 anatawa12 reopened this Jun 13, 2023
@anatawa12
Copy link
Owner

詳しい調査の結果この対処法が正しそうだったためreopenします。

@anatawa12 anatawa12 force-pushed the bugfix/merge-physbone-editor branch from 00bda58 to b025a47 Compare June 13, 2023 13:04
@anatawa12 anatawa12 enabled auto-merge June 13, 2023 13:20
@anatawa12 anatawa12 merged commit a8685f6 into anatawa12:master-0.4 Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MergePhysBoneでPhysBoneをD&Dで指定できない
2 participants