Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1] Update Gutenberg packages #6585

Merged
merged 18 commits into from
Aug 31, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions assets/src/admin/paired-browsing/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -429,12 +429,12 @@ class PairedBrowsingApp {
/**
* Receive loaded.
*
* @param {Object} data Data.
* @param {boolean} data.isAmpDocument Whether the document is actually an AMP page.
* @param {string} data.ampUrl The AMP URL.
* @param {string} data.nonAmpUrl The non-AMP URL.
* @param {string} data.documentTitle The title of the document.
* @param {Window} sourceWindow The source window.
* @param {Object} data Data.
* @param {boolean} data.isAmpDocument Whether the document is actually an AMP page.
* @param {string} data.ampUrl The AMP URL.
* @param {string} data.nonAmpUrl The non-AMP URL.
* @param {string} data.documentTitle The title of the document.
* @param {Window} sourceWindow The source window.
*/
receiveLoaded( { isAmpDocument, ampUrl, nonAmpUrl, documentTitle }, sourceWindow ) {
const isAmpSource = this.isAmpWindow( sourceWindow );
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ const onBeforeUnload = ( event ) => {
* If this does not exist yet, it creates the element.
*
* @param {number} numberErrorsDisplaying - The number of errors displaying.
* @param {number} totalErrors - The total number of errors, displaying or not.
* @param {number} totalErrors - The total number of errors, displaying or not.
*/
const updateShowingErrorsRow = ( numberErrorsDisplaying, totalErrors ) => {
const showAllButton = document.getElementById( showAllId );
Expand Down
2 changes: 1 addition & 1 deletion assets/src/amp-validation/amp-validation-detail-toggle.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const OPEN_CLASS = 'is-open';
* table column via backend code.
*
* @param {string} containerSelector Selector for elements that will have the button added.
* @param {string} ariaLabel Screen reader label for the button.
* @param {string} ariaLabel Screen reader label for the button.
* @return {Array} Array of added buttons.
*/
function addToggleButtons( containerSelector, ariaLabel ) {
Expand Down
2 changes: 1 addition & 1 deletion assets/src/amp-validation/copy-to-clipboard-buttons.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { getURLValidationTableRows } from './get-url-validation-table-rows';
/**
* Success handler, called when data is copied to the clipboard.
*
* @param {Object} event
* @param {Object} event
* @param {HTMLElement} event.trigger The element triggering the event.
*/
function onSuccess( { trigger } ) {
Expand Down
6 changes: 3 additions & 3 deletions assets/src/amp-validation/counts/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import './style.css';
* If the count is not a number or is `0`, the element that contains the count is instead removed (as it would be no longer relevant).
*
* @param {HTMLElement} itemEl Menu item element.
* @param {number} count Count to set.
* @param {number} count Count to set.
*/
function updateMenuItem( itemEl, count ) {
if ( isNaN( count ) || count === 0 ) {
Expand All @@ -29,9 +29,9 @@ function updateMenuItem( itemEl, count ) {
/**
* Updates the 'Validated URLs' and 'Error Index' menu items with their respective unreviewed count.
*
* @param {Object} counts Counts for menu items.
* @param {Object} counts Counts for menu items.
* @param {number} counts.validated_urls Unreviewed validated URLs count.
* @param {number} counts.errors Unreviewed validation errors count.
* @param {number} counts.errors Unreviewed validation errors count.
*/
function updateMenuItemCounts( counts ) {
const { validated_urls: newValidatedUrlCount, errors: newErrorCount } = counts;
Expand Down
2 changes: 1 addition & 1 deletion assets/src/amp-validation/get-url-validation-table-rows.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* Gets the table rows on a single URL validation screen.
*
* @param {Object} options
* @param {Object} options
* @param {boolean} options.checkedOnly Whether to return only checked rows.
*/
export function getURLValidationTableRows( options = {} ) {
Expand Down
8 changes: 4 additions & 4 deletions assets/src/block-editor/components/layout-controls.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ import { __, sprintf } from '@wordpress/i18n';
/**
* Layout controls for AMP blocks' attributes: layout, width, height.
*
* @param {Object} props Component props.
* @param {Object} props.attributes Block attributes.
* @param {Function} props.setAttributes Callback to update block attributes.
* @param {Array} props.ampLayoutOptions Layout options.
* @param {Object} props Component props.
* @param {Object} props.attributes Block attributes.
* @param {Function} props.setAttributes Callback to update block attributes.
* @param {Array} props.ampLayoutOptions Layout options.
* @return {ReactElement} Controls.
*/
const LayoutControls = ( { attributes, setAttributes, ampLayoutOptions } ) => {
Expand Down
4 changes: 2 additions & 2 deletions assets/src/block-editor/components/media-placeholder.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ import { __ } from '@wordpress/i18n';
/**
* Display media placeholder.
*
* @param {Object} props Component props.
* @param {Object} props Component props.
* @param {string} props.name Block's name.
* @param {string} props.url URL.
* @param {string} props.url URL.
* @return {ReactElement} Placeholder.
*/
const MediaPlaceholder = ( { name, url } ) => {
Expand Down
6 changes: 3 additions & 3 deletions assets/src/block-editor/helpers/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -316,10 +316,10 @@ export const filterBlocksEdit = ( BlockEdit ) => {
/**
* Set width and height in case of image block.
*
* @param {Object} props Props.
* @param {Object} props Props.
* @param {Function} props.setAttributes Callback to set attributes.
* @param {Object} props.attributes Attributes.
* @param {string} layout Layout.
* @param {Object} props.attributes Attributes.
* @param {string} layout Layout.
*/
export const setImageBlockLayoutAttributes = ( props, layout ) => {
const { attributes, setAttributes } = props;
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading