-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.1] Update Gutenberg packages #6585
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault/build/polyfill` See WordPress/gutenberg#31279 See WordPress/wordpress-develop#1361
Codecov Report
@@ Coverage Diff @@
## 2.1 #6585 +/- ##
============================================
- Coverage 75.74% 75.73% -0.02%
Complexity 5925 5925
============================================
Files 237 237
Lines 17942 17942
============================================
- Hits 13590 13588 -2
- Misses 4352 4354 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Plugin builds for cd561da are ready 🛎️!
|
For QA I think we should test the minimum version of WP we're supporting for dependencies: amp-wp/src/DependencySupport.php Line 33 in 2607345
|
westonruter
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initially this PR started off with updating the
@wordpress/components
package to the first version that would have the CSS necessary to fix the issue reported in #6235 (comment), but that later meant the other Gutenberg packages had to also be updated to prevent any breaking changes between them since they rely on each other. Updating those packages then affected some JS/CSS tests and prevented the project from being built, so I ultimately decided to update the set of Gutenberg packages to match the ones on thedevelop
branch, while also cherry-picking some changes along the way that would fix those tests and build errors.One benefit from these set of changes is that this branch should be more compatible with the latest version of Gutenberg and should reduce any likeliness of any UI/UX regressions we would expect on the
develop
branch.Fixes #6235
Checklist