Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1] Update Gutenberg packages #6585

Merged
merged 18 commits into from
Aug 31, 2021
Merged

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Aug 31, 2021

Summary

Initially this PR started off with updating the @wordpress/components package to the first version that would have the CSS necessary to fix the issue reported in #6235 (comment), but that later meant the other Gutenberg packages had to also be updated to prevent any breaking changes between them since they rely on each other. Updating those packages then affected some JS/CSS tests and prevented the project from being built, so I ultimately decided to update the set of Gutenberg packages to match the ones on the develop branch, while also cherry-picking some changes along the way that would fix those tests and build errors.

One benefit from these set of changes is that this branch should be more compatible with the latest version of Gutenberg and should reduce any likeliness of any UI/UX regressions we would expect on the develop branch.

Fixes #6235

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@pierlon pierlon changed the title Update Gutenberg packages [2.1] Update Gutenberg packages Aug 31, 2021
@pierlon pierlon added the dependencies Pull requests that update a dependency file label Aug 31, 2021
@pierlon pierlon added this to the v2.1.4 milestone Aug 31, 2021
@pierlon pierlon self-assigned this Aug 31, 2021
@pierlon pierlon requested a review from westonruter August 31, 2021 01:00
@pierlon pierlon marked this pull request as ready for review August 31, 2021 01:13
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #6585 (cd561da) into 2.1 (4205e6e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.1    #6585      +/-   ##
============================================
- Coverage     75.74%   75.73%   -0.02%     
  Complexity     5925     5925              
============================================
  Files           237      237              
  Lines         17942    17942              
============================================
- Hits          13590    13588       -2     
- Misses         4352     4354       +2     
Flag Coverage Δ
javascript 78.86% <100.00%> (-0.26%) ⬇️
php 75.59% <ø> (ø)
unit 75.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
assets/src/block-editor/helpers/index.js 39.28% <ø> (ø)
...block-validation/components/error/error-content.js 93.54% <ø> (ø)
...k-validation/components/error/error-panel-title.js 100.00% <ø> (ø)
...sets/src/block-validation/components/icon/index.js 100.00% <ø> (ø)
...alidation/components/sidebar-notification/index.js 100.00% <ø> (ø)
...dation/components/with-amp-toolbar-button/index.js 100.00% <ø> (ø)
...dation/hooks/use-validation-error-state-updates.js 85.07% <ø> (ø)
assets/src/common/helpers/index.js 91.22% <ø> (ø)
assets/src/components/amp-drawer/index.js 73.07% <ø> (ø)
assets/src/components/amp-info/index.js 100.00% <ø> (ø)
... and 14 more

@github-actions
Copy link
Contributor

Plugin builds for cd561da are ready 🛎️!

@westonruter
Copy link
Member

westonruter commented Aug 31, 2021

Looking good! With 2.1.4-alpha vs 2.1.4-alpha-20210831T011634Z-cd561dafb:

Before After
Screen Shot 2021-08-30 at 19 55 10 Screen Shot 2021-08-30 at 19 57 12

And it looks the same with Gutenberg deactivated.

@pierlon
Copy link
Contributor Author

pierlon commented Aug 31, 2021

For QA I think we should test the minimum version of WP we're supporting for dependencies:

const WP_MIN_VERSION = '5.6';

@westonruter westonruter merged commit e112dae into 2.1 Aug 31, 2021
@westonruter westonruter deleted the 2.1-update-gutenberg-packages branch August 31, 2021 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants