Require double click (or just two clicks) for editing.

[miina]

Closes #2783.

Requires double click for editing the Text block.

Todo:

• Display edit mode only on double click.
• Remove dragging area border and related logic.
• Don't allow dragging in edit mode.
• Better focus when going into edit mode.
• e2e tests.

[kienstra]

Hi @miina,
This looks good. Editing and dragging of the Text block works well:

In my opinion, requiring a double-click to edit might be a little too much.

For example, Preview from macOS also allows dragging the entire text element. But editing text only requires one click, once the text is focused.

Though that's a requirement from #2783, and this PR applies it well.

[swissspidy]

In my opinion, requiring a double-click to edit might be a little too much.

Agreed. When the block is already selected, just requiring a single click would be nice. Not sure if that causes conflicts with dragging though.

[miina]

Agreed. When the block is already selected, just requiring a single click would be nice. Not sure if that causes conflicts with dragging though.

Will try it out.

[swissspidy]

Just merged #2824, so this needs some updates.

That PR mentions:

Update the logic once #2863 gets merged.

[miina]

Looks like core-editor.test.js was failing due to switchEditorModeTo not waiting for the selector being available.

At least now it works locally, hopefully, fixes it here, too.

[miina]

@swissspidy Mind giving it another review?

[miina]

Maybe it would make sense to move this to DraggableText as well actually.

[miina]

Could rename it to DraggableRichText. Would make a more complete component. Thoughts?

[miina]

Although maybe it would make the component confusing with that many attributes.

[swissspidy]

I think for now we can keep it as-is.

[miina]

Not sure why the CTA warning message test is failing here, not happening locally. Looking into this ...

[miina]

Looks like the tests are OK now finally.