Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Text block regressions #2630

Closed
miina opened this issue Jun 14, 2019 · 2 comments
Closed

Investigate Text block regressions #2630

miina opened this issue Jun 14, 2019 · 2 comments
Labels
Enhancement New feature or improvement of an existing one

Comments

@miina
Copy link
Contributor

miina commented Jun 14, 2019

Looks like multiple regressions were caused for Text block by:

  1. Vertical centering.
  2. Dragging the whole block.

Would be good to investigate if there are simpler ways to achieve the same goals to make all the padding and border considerations more manageable.

Currently, we have to add and subtract the draggable area borders and the paddings in various places and all this makes the logic quite confusing. Perhaps this needs another look.

@miina miina added Enhancement New feature or improvement of an existing one AMP Stories labels Jun 14, 2019
@swissspidy swissspidy added this to the v1.2.1 milestone Jun 14, 2019
@swissspidy
Copy link
Collaborator

Agreed that there's quite some complexity around this block now. This makes it harder to maintain the code there. Would be good to look into is for 1.2.1 or 1.3.

@swissspidy swissspidy modified the milestones: v1.2.1, v1.3 Jul 15, 2019
@miina
Copy link
Contributor Author

miina commented Jul 24, 2019

Note that #2863 reduces the complexity quite a bit by reverting the extra border calculations.

@swissspidy swissspidy removed this from the v1.3 milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement of an existing one
Projects
None yet
Development

No branches or pull requests

3 participants