Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch security exceptions when fetching adid #167

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

catch security exceptions when fetching adid #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a9301e
catch security exceptions when fetching adid
djih Jul 3, 2018
df7befe
update changelog
djih Jul 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## Unreleased

* Catch SecurityExceptions thrown during fetching of Google Advertising ID. This is caused by older versions of Google Play Services using `MODE_WORLD_READABLE` when reading from SharedPreferences. If you see this warning you should update your version of Google Play Services.

## 2.18.1 (May 07, 2018)

* Updating to [OkHttp 3.10.0](https://github.com/square/okhttp/blob/master/CHANGELOG.md#version-3100)
Expand Down
2 changes: 2 additions & 0 deletions src/com/amplitude/api/DeviceInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,8 @@ private String getAndCacheGoogleAdvertisingId() {
AmplitudeLog.getLogger().w(TAG, "Google Play Services SDK not found!");
} catch (InvocationTargetException e) {
AmplitudeLog.getLogger().w(TAG, "Google Play Services not available");
} catch (SecurityException e) {
AmplitudeLog.getLogger().w(TAG, "Please update Google Play Services version");
} catch (Exception e) {
AmplitudeLog.getLogger().e(TAG, "Encountered an error connecting to Google Play Services", e);
}
Expand Down