catch security exceptions when fetching adid #167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ticket reporting this crash:
I investigated a little bit. We're calling
com.google.android.gms.ads.identifier.AdvertisingIdClient.getAdvertisingIdInfo
to fetch the ADID, and it looks like that attempts to pull SharedPrefs with modeMODE_WORLD_READABLE
. That mode has been deprecated since Android M due to a security vulnerability, and now in Android N it actually throws a SecurityException link hereThe issue is that the implementation of
getAdvertisingIdInfo
depends entirely on the Google Play Services library. The solution is to tell the customer / user of our SDK to update their version of GPS link here. Unfortunately I think the only thing we can do in our SDK is just to catchSecurityExceptions
when attempting to fetch the ADID.