Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix test suite #1354

Merged
merged 5 commits into from
Jan 24, 2024
Merged

ci: fix test suite #1354

merged 5 commits into from
Jan 24, 2024

Conversation

Nytelife26
Copy link
Member

This relates to...

N/A

Rationale

The lint and test suites are consistently failing due to outdated actions and
their corresponding metadata.

@Nytelife26 Nytelife26 requested a review from suchow as a code owner August 7, 2023 02:17
@Nytelife26 Nytelife26 added type: ci Issues and PRs related to continuous integration. priority: urgent Issues and PRs that must be resolved immediately. version: patch Issues and PRs with bug fixes belonging to the next patch release. status: wip Issues and PRs that are still a work in progress. cat: maintenance Issues and PRs related to the maintenance of a module. labels Aug 7, 2023
@Nytelife26 Nytelife26 force-pushed the ci/fix-test branch 3 times, most recently from 3781e8f to f3d886c Compare August 7, 2023 02:58
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.25% ⚠️

Comparison is base (6e4b612) 94.57% compared to head (4cbeaf0) 94.32%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1354      +/-   ##
==========================================
- Coverage   94.57%   94.32%   -0.25%     
==========================================
  Files          87       87              
  Lines        1198     1199       +1     
==========================================
- Hits         1133     1131       -2     
- Misses         65       68       +3     
Flag Coverage Δ
macos-latest 94.24% <50.00%> (-0.33%) ⬇️
py3.10 94.32% <50.00%> (?)
py3.6 ?
py3.7 ?
py3.8 94.40% <50.00%> (-0.17%) ⬇️
py3.9 94.40% <50.00%> (-0.17%) ⬇️
pypypy3 ?
pypypy3.10 94.32% <50.00%> (?)
pypypy3.9 94.40% <50.00%> (?)
ubuntu-latest 94.32% <50.00%> (-0.25%) ⬇️
windows-latest 94.24% <50.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
proselint/tools.py 86.55% <0.00%> (-1.00%) ⬇️
proselint/checks/lexical_illusions/misc.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

path resolution was not padding slashes enough on windows in
illegal-chars
note the removal of futures in this commit.
this removes the need for #1353 but it was necessary to clear setuptools legacy.
@Nytelife26 Nytelife26 merged commit 629af47 into main Jan 24, 2024
33 checks passed
@Nytelife26 Nytelife26 mentioned this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: maintenance Issues and PRs related to the maintenance of a module. priority: urgent Issues and PRs that must be resolved immediately. status: wip Issues and PRs that are still a work in progress. type: ci Issues and PRs related to continuous integration. version: patch Issues and PRs with bug fixes belonging to the next patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants