Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless dependency? #1352

Closed
frenzymadness opened this issue Jul 20, 2023 · 2 comments
Closed

Useless dependency? #1352

frenzymadness opened this issue Jul 20, 2023 · 2 comments
Assignees
Labels
cat: maintenance Issues and PRs related to the maintenance of a module. priority: low Issues and PRs that should be resolved, but can be postponed. status: wip Issues and PRs that are still a work in progress. type: chore Issues and PRs related to changes that do not fit into other categories. version: patch Issues and PRs with bug fixes belonging to the next patch release.

Comments

@frenzymadness
Copy link

I see that this project depends on future:

future = "^0.18.2"

but I cannot find any real usage of this library here. Why do I care about it? future will no longer work with Python 3.12 because imp module has been removed from stdlib and the situation will be even worse with 3.13 because the lib2to3 which is the core of the future will be removed from stdlib as well.

@Nytelife26
Copy link
Member

You do not have to justify why you might care about the existence of a useless dependency. The importance of compatibility and a tidy bundle size cannot be overstated. To the best of my knowledge, this dependency is residual from prior Python 2 support.

I am unsure of the direction @suchow would take with this, but realistically the ecosystem has long surpassed the need to continue supporting Python 2, and I cleaned up the project to remove all need for future a while ago. I would be in favour of removing it.

@Nytelife26 Nytelife26 added type: chore Issues and PRs related to changes that do not fit into other categories. priority: low Issues and PRs that should be resolved, but can be postponed. version: patch Issues and PRs with bug fixes belonging to the next patch release. status: wip Issues and PRs that are still a work in progress. cat: maintenance Issues and PRs related to the maintenance of a module. labels Jul 27, 2023
@Nytelife26
Copy link
Member

Resolved passively in #1354.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: maintenance Issues and PRs related to the maintenance of a module. priority: low Issues and PRs that should be resolved, but can be postponed. status: wip Issues and PRs that are still a work in progress. type: chore Issues and PRs related to changes that do not fit into other categories. version: patch Issues and PRs with bug fixes belonging to the next patch release.
Projects
None yet
Development

No branches or pull requests

3 participants