-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(GUI): Redesign and fix parts of the gui to be more responsive #251
Conversation
e21ac3b
to
75531f6
Compare
Merge conflicts resolved. |
Co-authored-by: zino212 <[email protected]> Signed-off-by: simonsasse <[email protected]>
Co-authored-by: zino212 <[email protected]> Signed-off-by: simonsasse <[email protected]>
Co-authored-by: zino212 <[email protected]> Signed-off-by: simonsasse <[email protected]>
Co-authored-by: simonsasse <[email protected]> Signed-off-by: zino212 <[email protected]>
Co-authored-by: simonsasse <[email protected]> Signed-off-by: zino212 <[email protected]>
Co-authored-by: simonsasse <[email protected]> Signed-off-by: zino212 <[email protected]>
Co-authored-by: simonsasse <[email protected]> Signed-off-by: zino212 <[email protected]>
Co-authored-by: zino212 <[email protected]> Signed-off-by: simonsasse <[email protected]>
Signed-off-by: simonsasse <[email protected]>
Signed-off-by: simonsasse <[email protected]>
Signed-off-by: simonsasse <[email protected]>
Signed-off-by: simonsasse <[email protected]>
Signed-off-by: simonsasse <[email protected]>
Signed-off-by: zino212 <[email protected]>
Signed-off-by: zino212 <[email protected]>
Signed-off-by: zino212 <[email protected]>
Signed-off-by: zino212 <[email protected]>
… tooltip Signed-off-by: zino212 <[email protected]>
Signed-off-by: zino212 <[email protected]>
207ad9c
to
f91f5b5
Compare
Rebased 😓 |
Signed-off-by: simonsasse <[email protected]>
This should be reviewed by 2-3 people before being merged !! |
Great changes :) Couple things, I noticed: |
Signed-off-by: zino212 <[email protected]>
@akriese: For now I decided to just move the save button into the right corner. Moving it into the appbar brings possible problems it, because the differentiation between saving and just going back would have to be made very clear. I don't know if positioning the button on the left next to the back button would be better or positioning it to the right. On the left the user would probably be more likely to see it than on the right but maybe it being so close to the back button would also be problematic. In less words: The button being in the lower right corner is in my opinion for now the solution with the least problems. :) |
Signed-off-by: zino212 <[email protected]>
The scaling of the full screen button seems to be a bit tricky. I set a maximum size for the vertical size for now. The horizontal size is responsive to the overall window size and therefore can not be set this way. Additionally, I have no real clue on how to set a minimum size for the icons or how to make them scale linear with the buttons. I tried several things which didn't work out. Maybe @simonsasse has some ideas? |
Signed-off-by: simonsasse <[email protected]>
Signed-off-by: simonsasse <[email protected]>
Signed-off-by: simonsasse <[email protected]>
OKaaaay. I changed the fullscreen button to be a plain IconButton. Looks cleaner and does not scale ugly. I centered the download dropdown on the image. I am sure, it is possible to get the exact location and place it there but maybe that's not the most relevant thing for now. |
Signed-off-by: simonsasse <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all, this LGTM. Let's wait for at least one more positive review though :)
Signed-off-by: simonsasse <[email protected]>
Closes #235
TODO
Diff view:
Fullscreen view
Settings view:
Select view:
General:
Remarks from Anton:
Diff Screen
Difference Screen
headline in the topbar overlaps with the buttons on the left, if the window's width is low enoughSave image as png
does not pop up where the mouse was clicked (Well not really fixed)Settings screen
Changes for other PRs