Improvements to the Video Selections Process #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs3itz
force-pushed
the
gui/feature/video-selection-improvements
branch
from
adae0b2 to
94a9d90
Compare
|
rebased onto main |
fs3itz
requested review from
a team and
akriese
and removed request for
a team
akriese
reviewed
Jan 29, 2024
|
I think, we should merge #251 before this and then rebase this again if there are conflicts |
added video format check on video selection added fileChooserFilter to filter for certain File Extensions Signed-off-by: Fabian Seitz <[email protected]>
Signed-off-by: Fabian Seitz <[email protected]>
fs3itz
force-pushed
the
gui/feature/video-selection-improvements
branch
from
4648db4 to
7b06f0b
Compare
|
rebased onto main after #251 was merged |
Signed-off-by: Fabian Seitz <[email protected]>
Signed-off-by: Fabian Seitz <[email protected]> - fixed linting in lib 2 Signed-off-by: Fabian Seitz <[email protected]> - fixed rebase issues - moved codec checking into lib2 - changed projectManager allowed file extensions from json to mkv Signed-off-by: Fabian Seitz <[email protected]>
fs3itz
force-pushed
the
gui/feature/video-selection-improvements
branch
from
e9de3de to
6b7aefe
Compare
- replaced isLosslessCodec in DifferenceGenerator with checkFile Signed-off-by: Fabian Seitz <[email protected]>
Signed-off-by: Fabian Seitz <[email protected]>
fs3itz
force-pushed
the
gui/feature/video-selection-improvements
branch
from
9689399 to
9d64f18
Compare
akriese
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.