Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 1.8.3. #29

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Update to 1.8.3. #29

merged 1 commit into from
Apr 4, 2024

Conversation

marcoag
Copy link
Contributor

@marcoag marcoag commented Apr 4, 2024

Updating to 1.8.3 to match the version in noble: https://packages.ubuntu.com/noble/libbenchmark1.8.3

With this changes we also build from source if the package version is less than 1.8.3 but let me know if we should do otherwise.

@marcoag
Update to 1.8.3.
1f3d368 
Signed-off-by: Marco A. Gutierrez <[email protected]>
@marcoag marcoag requested a review from cottsay as a code owner April 4, 2024 08:59
@marcoag marcoag requested review from clalancette and removed request for cottsay April 4, 2024 08:59
@marcoag
Copy link
Contributor Author

marcoag commented Apr 4, 2024 •
edited by clalancette
Loading

Ci:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

ahcorde
ahcorde requested changes Apr 4, 2024
View reviewed changes
Copy link

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see this error on Windows:

11:18:22 ==> curl -skL marcoag/google_benchmark_1.8.3 -o 00-google_benchmark_1.8.3
11:18:23 <== 'curl -skL marcoag/google_benchmark_1.8.3 -o 00-google_benchmark_1.8.3' exited with return code '6'

@marcoag marcoag mentioned this pull request Apr 4, 2024
Closed
@clalancette
Copy link
Contributor

I can see this error on Windows:

The CI run just had the wrong arguments; I've kicked it off again with the correct ones.

@ahcorde ahcorde merged commit 189599d into rolling Apr 4, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the marcoag/google_benchmark_1.8.3 branch April 4, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@clalancette clalancette Awaiting requested review from clalancette

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcoag @clalancette @ahcorde