Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendor packages #23

Closed
clalancette opened this issue May 2, 2023 · 5 comments
Closed

Update vendor packages #23

clalancette opened this issue May 2, 2023 · 5 comments
Assignees

Comments

@clalancette
Copy link

No description provided.

@clalancette clalancette converted this from a draft issue May 2, 2023
@clalancette
Copy link
Author

clalancette commented May 2, 2023

Upgrade the vendor packages to match what is in the Ubuntu distribution currently being used. For instance, Humble was on Ubuntu 22.04, so make the vendor packages match whatever versions are packaged in Ubuntu 22.04.

Basically update these repos:
https://github.com/search?q=org%3Aros2+vendor&type=repositories

Note: When doing these bumps also run CI for windows debug.

@marcoag marcoag self-assigned this Apr 2, 2024
@marcoag marcoag moved this to In Progress in Jazzy Jalisco Apr 3, 2024
@clalancette
Copy link
Author

List of vendor repos and whoever is working on upgrade:

* [ ]  [ros2/tinyxml_vendor](https://github.com/ros2/tinyxml_vendor) @marcoag Not needed?

Correct, we no longer depend on this one. We can skip it.

* [ ]  [ros2/libyaml_vendor](https://github.com/ros2/libyaml_vendor) @marcoag

* [ ]  [ros2/darknet_vendor](https://github.com/ros2/darknet_vendor)

We can skip this one; it is not in the core.

* [ ]  [ros2/mimick_vendor](https://github.com/ros2/mimick_vendor)

* [ ]  [ros2/yaml_cpp_vendor](https://github.com/ros2/yaml_cpp_vendor) @marcoag [Upgrade to yaml-cpp 0.8.0 yaml_cpp_vendor#48](https://github.com/ros2/yaml_cpp_vendor/pull/48)

* [ ]  [ros2/tinyxml2_vendor](https://github.com/ros2/tinyxml2_vendor) @marcoag same as tinyxml?

* [ ]  [ros2/spdlog_vendor](https://github.com/ros2/spdlog_vendor) @marcoag [Upgrade to v1.12.0. spdlog_vendor#35](https://github.com/ros2/spdlog_vendor/pull/35)

* [ ]  [ros2/pybind11_vendor](https://github.com/ros2/pybind11_vendor)

* [ ]  [ros2/poco_vendor](https://github.com/ros2/poco_vendor)

We can skip this one; the core doesn't depend on it anymore.

* [ ]  [ros2/console_bridge_vendor](https://github.com/ros2/console_bridge_vendor)

* [ ]  [ros2/tinydir_vendor](https://github.com/ros2/tinydir_vendor)

We can skip this one; the core doesn't depend on it anymore.

* [ ]  [ros2/orocos_kdl_vendor](https://github.com/ros2/orocos_kdl_vendor)

* [ ]  [ros2/ifcfg_vendor](https://github.com/ros2/ifcfg_vendor)

We can skip this one; the core doesn't depend on it anymore.

I'm going to go through the previous comment and strike-out the ones that we don't need to do.

@ahcorde
Copy link

ahcorde commented Apr 12, 2024

can we consider this as done ? @marcoag and @clalancette ?

@clalancette
Copy link
Author

Yes! Good call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

No branches or pull requests

3 participants