Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address todos #730

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: address todos #730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/braket/jobs/hybrid_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@ def hybrid_job(

include_modules (Union[Union[str, ModuleType], Iterable[Union[str, ModuleType]]]): Either a
single module or module name or a list of module or module names referring to local
modules to be included. Default value `[]`
todo: confirm docs
modules to be included. Any references to members of these modules in the hybrid job
algorithm code will be serialized as part of the algorithm code. Default value `[]`

dependencies (Optional[Union[str, Path]]): Path (absolute or relative) to a requirements.txt
file to be used. todo: confirm docs
file to be used for the hybrid job.

local (bool): Whether to use local mode for the hybrid job. Default `False`

Expand Down Expand Up @@ -213,7 +213,6 @@ def __exit__(self, exc_type, exc_val, exc_tb):
def _serialize_entry_point(entry_point: Callable, args, kwargs) -> str:
"""Create an entry point from a function"""

# todo: catch serialization errors
def wrapped_entry_point():
"""Partial function wrapping entry point with given parameters"""
return entry_point(*args, **kwargs)
Expand Down
2 changes: 0 additions & 2 deletions test/unit_tests/braket/jobs/test_data_persistence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
import numpy as np
import pytest

# todo: remove once circular import is fixed
import braket.aws # noqa: F401
from braket.jobs.data_persistence import (
load_job_checkpoint,
load_job_result,
Expand Down