Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address todos #730

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: address todos #730

merged 1 commit into from
Oct 9, 2023

Conversation

ajberdy
Copy link
Contributor

@ajberdy ajberdy commented Oct 9, 2023

Issue #, if available:

Description of changes:

Assert circular import is resolved and update pending docs

Testing done:

unit tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ajberdy ajberdy requested a review from a team as a code owner October 9, 2023 19:12
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0db4972) 99.96% compared to head (e10b368) 99.96%.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/job-decorator     #730   +/-   ##
======================================================
  Coverage                  99.96%   99.96%           
======================================================
  Files                        129      129           
  Lines                       8336     8336           
  Branches                    1857     1857           
======================================================
  Hits                        8333     8333           
  Misses                         2        2           
  Partials                       1        1           
Files Coverage Δ
src/braket/jobs/hybrid_job.py 97.02% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajberdy ajberdy merged commit a7e799c into feature/job-decorator Oct 9, 2023
28 checks passed
@ajberdy ajberdy deleted the fix-import branch October 9, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants