feat: job decorator #729
Merged
feat: job decorator #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matthew Beach <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #729 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 127 129 +2
Lines 8237 8387 +150
Branches 1832 1866 +34
==========================================
+ Hits 8237 8387 +150
☔ View full report in Codecov by Sentry. |
|
2 loc missing coverage and a few dangling todos remaining |
speller26
reviewed
Oct 10, 2023
src/braket/jobs/hybrid_job.py
Outdated
| from logging import Logger, getLogger | ||
| from pathlib import Path | ||
| from types import ModuleType | ||
| from typing import Any, Callable, Dict, Iterable, Optional, Union |
There was a problem hiding this comment.
We've now deprecated Python 3.8, so you no longer have to import Callable, Dict and Iterable
There was a problem hiding this comment.
Exciting, I will update this PR to use 3.9+ syntax
to resolve with #741
Co-authored-by: Aaron Berdy <[email protected]>
kshitijc
reviewed
Oct 16, 2023
src/braket/jobs/hybrid_job.py
Outdated
Comment on lines
267
to
272
| "Serialization failed for decorator hybrid job. For troubleshooting, " | ||
| "see the developer guide: #todo: link to docs with info as below" | ||
| # "Serialization failed for decorator hybrid job. If you are referencing " | ||
| # "an object from outside the function scope, either directly or through " | ||
| # "function parameters, try instantiating the object inside the decorated " | ||
| # "function instead." |
There was a problem hiding this comment.
Good call, I'm guessing we won't have the docs till after the launch? So I can put a temporary error message with the content itself instead of a link
kshitijc
previously approved these changes
Oct 16, 2023
src/braket/jobs/hybrid_job.py
Outdated
| tags: dict[str, str] = None, | ||
| logger: Logger = getLogger(__name__), | ||
| ) -> Callable: | ||
| """Creates a job by invoking the Braket CreateJob API. |
There was a problem hiding this comment.
This isn't valid if local=True. Could we update to make it unambiguous?
kshitijc
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Enable running jobs via decorated functions!
Testing done:
Unit/integ/manual
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.