Add results, state vector, amplitude, probability #60
Conversation
src/braket/circuits/results.py
Outdated
| self._target = QubitSet(target) | ||
|
|
||
| def to_ir(self) -> ir.Probability: | ||
| return ir.Probability(targets=list(self.target)) |
There was a problem hiding this comment.
self.target should be converted to a list of ints; the local simulators will consume the output of to_ir directly, and SDK classes should not be exposed there. Same applies to any other to_ir definitions that contain an SDK class within the returned value.
There was a problem hiding this comment.
Qubit is a subclass of int. Even if the local simulators consume the output of to_ir directly, I don't think it would be an issue because it's still an int.
src/braket/circuits/__init__.py
Outdated
| from braket.circuits.result_type import ResultType # noqa: F401 | ||
| from braket.circuits.result_types import Amplitude, Probability, StateVector # noqa: F401 |
There was a problem hiding this comment.
Not going to reopen the discussion about naming, but seems like having left Result (or ResultBase) and suffixing all the child classes with Result (such as AmplitudeResult) would be more accurate and prevent naming collisions should we need to add additional Amplitude, Probability, or StateVector classes that are something other than Results in the future.
There was a problem hiding this comment.
I'll remove this line and just import in result_types as result_types so that these can just be referred to as ResultType.Amplitude, etc. to avoid naming collisions in the circuits namespace. If users want they can also import in the classes directly and use them.
Issue #, if available:
*Description of changes:
build_files.tar.gz
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.