Skip to content

Commit

Permalink
fix: Remove tags (#60)
Browse files Browse the repository at this point in the history
  • Loading branch information
kshitijc authored Sep 13, 2021
1 parent 0edbd62 commit bb55bda
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 16 deletions.
7 changes: 0 additions & 7 deletions src/braket/aws/aws_quantum_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ def create(
copy_checkpoints_from_job: str = None,
checkpoint_config: CheckpointConfig = None,
vpc_config: VpcConfig = None,
tags: Dict[str, str] = None,
aws_session: AwsSession = None,
*args,
**kwargs,
Expand Down Expand Up @@ -161,9 +160,6 @@ def create(
vpc_config (VpcConfig): Configuration specifying the security groups and subnets
to use for running the job. Default: None.
tags (Dict[str, str]): Dict specifying the Key-Value pairs to tag the quantum job with.
Default: None.
aws_session (AwsSession): AwsSession to connect to AWS with. Default: AwsSession()
Returns:
Expand All @@ -182,7 +178,6 @@ def create(
stopping_condition = stopping_condition or StoppingCondition()
output_data_config = output_data_config or OutputDataConfig()
checkpoint_config = checkpoint_config or CheckpointConfig()
# tags = tags or {}
default_bucket = aws_session.default_bucket()
code_location = code_location or aws_session.construct_s3_uri(
default_bucket,
Expand Down Expand Up @@ -237,8 +232,6 @@ def create(
"deviceConfig": asdict(device_config),
"hyperParameters": hyperparameters,
"stoppingCondition": asdict(stopping_condition),
# TODO: uncomment when tags works
# "tags": tags,
}

if vpc_config:
Expand Down
9 changes: 0 additions & 9 deletions test/unit_tests/braket/aws/test_aws_quantum_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -518,11 +518,6 @@ def vpc_config():
)


@pytest.fixture
def tags():
return {"tagKey": "tagValue"}


@pytest.fixture(params=["fixtures", "defaults", "nones"])
def create_job_args(
request,
Expand All @@ -542,7 +537,6 @@ def create_job_args(
output_data_config,
checkpoint_config,
vpc_config,
tags,
):
if request.param == "fixtures":
return dict(
Expand All @@ -564,7 +558,6 @@ def create_job_args(
"output_data_config": output_data_config,
"checkpoint_config": checkpoint_config,
"vpc_config": vpc_config,
"tags": tags,
"aws_session": aws_session,
}.items()
if value is not None
Expand Down Expand Up @@ -667,7 +660,6 @@ def _assert_create_job_called_with(
}
if image_uri:
algorithm_specification["containerImage"] = {"uri": image_uri}
# tags = create_job_args["tags"] or {}

test_kwargs = {
"jobName": job_name,
Expand All @@ -680,7 +672,6 @@ def _assert_create_job_called_with(
"deviceConfig": {"devices": devices},
"hyperParameters": hyperparameters,
"stoppingCondition": asdict(stopping_condition),
# "tags": tags,
}

if vpc_config:
Expand Down

0 comments on commit bb55bda

Please sign in to comment.